feat(cli): archive list option to filter by name prefix. Fixes #10524
#13794
Conversation
agilgur5
changed the title
archive list option to filter by name prefix (#10524)archive list option to filter by name prefix. Fixes #10524
| if err != nil { | ||
| return err | ||
| } | ||
| return printer.PrintWorkflows(workflows, os.Stdout, printer.PrintOpts{Output: output.String(), Namespace: true, UID: true}) | ||
| }, | ||
| } | ||
| command.Flags().VarP(&output, "output", "o", "Output format. "+output.Usage()) | ||
| command.Flags().StringVar(&prefix, "prefix", "", "Filter workflows by prefix") |
There was a problem hiding this comment.
I feel like this should be more specific like "name prefix"; the API parameter is NamePrefix too, so it would be good to match
| command.Flags().StringVar(&prefix, "prefix", "", "Filter workflows by prefix") | |
| command.Flags().StringVar(&prefix, "name-prefix", "", "Filter workflows by name prefix") |
There was a problem hiding this comment.
It would also make sense to consider the UX/style of #13160, where --name can be modified by --name-filter, which is one of "Exact" / "Prefix" / "Pattern".
Although it didn't implement that for the Archived List API specifically, but I think that API is capable of both "Exact" and "Prefix" already, so we can make the CLI syntax/UX match the newer List API
There was a problem hiding this comment.
I see --prefix and the description verbatim match the list CLI, so perhaps we leave that in for backward-compat but also add --name and --name-filter to match #13160.
We could also remove it in a breaking CLI change or just only add the new variant to the archive list command so that there's nothing to deprecate later.
Fixes #10524